Update gsd/develop from NOAA-EMC develop#43
Merged
DomHeinzeller merged 9 commits intoAug 7, 2020
Merged
Conversation
* point to the dycore branch with Toms fix * update Toms regional DA fix * merge to fv3 develop branch * add Dans Changes for when INTERNAL_FILE_NML is not used and update ccpp framework/physics * remove hardcoded levp=65 for source_FV3GFS * point back to EMC dycore repo Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com>
This PR contains cleanup work to address wrong units and some issues raised in recently merged PRs: - correct units for latitude, longitude, and pi - correct standard name air_temperature_save_from_cumulus_paramterization to air_temperature_save_from_convective_parameterization - remove unused variables in two routines in `GFS_typedefs.F90` - remove recently introduced variable `cycling` (part of GFS_control DDT), now a local variable in `physics/module_MYNNPBL_wrapper.F90` - change order of interstitial schemes in `ccpp/suites/suite_FV3_GFS_2017_fv3wam.xml` to match other SDFs Fixes NOAA-EMC#138 and parts of NOAA-EMC#137.
* This is EMC flake model * Updated .gitmodules file under FV3 * Removed the reset of lake fraction and lake depth statements * point to ccpp physics branch flake * Reset lkm to 0 * Swapped the order of calls in the suite file * update to the latest ccpp/physics branch * Revert change to .gitmodules and update submodule pointer for ccpp-physics
…0/07/21) (NOAA-EMC#147) - remove `include ./depend` from several GNU makefiles (from @DusanJovic-NOAA) - correct CCPP version number in several suite definition files - GFS_typedefs.F90: allow using `iopt_snf == 4` for other microphysics schemes than GFDL MP (required for RRFS, needs NoahMP and Thompson)
…OAA-EMC#150) As the title says. Note that the affected files are for the gnumake build - if we had transitioned entirely to cmake, we wouldn't need to maintain these files any longer.
…A-EMC#145) * atmos_model.F90: remove dependency of stochastic physics on IPD_Control * Add mpi_wrapper to stochastic_physics to substitute calls to fv_mp_mod routines * Make cellular automata code independent of fv_mp_mod * Make cellular automata code independent of atmosphere_mod * Add halo exchange routine to stochastic_physics code * Remove dependency on GFS_coupling_type from stochastic_physics.F90 * Remove dependency on GFS_grid_type in stochastic_physics and stochastic_physics_sfc * Cleanup work, avoid unnecessary data copies * Move stochastic physics code into its own wrapper/driver * Remove dependency on Statein, Coupling and Intdiag DDT from cellular_automata_sgs.F90 * Compile kinddef module, cleanup stochastic_physics_wrapper.F90 * Update cmake build system * Fix a bug in atmos_model.F90, inadvertetly removed a closing parenthesis * Update to build system for stochastic_physics_wrapper following cmake updates * Update gnumake build to include stochastic_physics wrapper * Remove commented out lines from stochastic_physics/makefile Co-authored-by: Jun Wang <jun.wang@noaa.gov>
This was referenced Aug 6, 2020
…tmos_cubed_sphere, ccpp-framework, ccpp-physics
DomHeinzeller
approved these changes
Aug 7, 2020
zhanglikate
referenced
this pull request
in zhanglikate/ufsatm
Oct 7, 2025
* update parallel netcdf module files on dell * update fv3 to netcdf_parallel branch * update module files for hera, dell and conf file for cray * update post lib in cray module file * fix netlib on hera * Update FV3 submodule * Update baselines to develop-20200202 * Regtest logs on wcoss_dell_p3 * Regtest logs on wcoss_cray * Regtest logs on hera * update FV3 to point to NOAA-EMC develop branch Co-authored-by: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated PRs:
NOAA-GSL/ufs-weather-model#35
#43
NOAA-GSL/ccpp-physics#48
NOAA-GSL/ccpp-framework#7
NOAA-GSL/GFDL_atmos_cubed_sphere#7
For regression testing information, see NOAA-GSL/ufs-weather-model#35.